Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix generate plugin #692

Merged
merged 4 commits into from
Jan 6, 2024
Merged

Conversation

big-kahuna-burger
Copy link
Contributor

Closes #690

Checklist

@big-kahuna-burger
Copy link
Contributor Author

Not sure why using runner gives this flaky behaviour...

@mcollina
Copy link
Member

mcollina commented Jan 2, 2024

Does the plugin generator use node:test?

@big-kahuna-burger
Copy link
Contributor Author

Does the plugin generator use node:test?

Yes. Check here

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@big-kahuna-burger
Copy link
Contributor Author

Merge and patch release?

@mcollina mcollina merged commit 6505838 into fastify:master Jan 6, 2024
14 checks passed
@big-kahuna-burger big-kahuna-burger deleted the v6-patches branch January 6, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate plugin nitpicks to work out of the box
2 participants