Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove request dependency #57

Closed
jsumners opened this issue Jan 5, 2020 · 1 comment
Closed

Remove request dependency #57

jsumners opened this issue Jan 5, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jsumners
Copy link
Member

jsumners commented Jan 5, 2020

The request library has been deprecated and (essentially) abandoned for a long time. We should rely on another library like got for testing (or simply use fastify.inject if possible).
@jsumners jsumners added the good first issue Good for newcomers label Jan 5, 2020
Svjard added a commit to Svjard/fastify-cookie that referenced this issue Jan 6, 2020
@Svjard
fastify#57 - Moved tests over to use fastify inject
558799a
Svjard added a commit to Svjard/fastify-cookie that referenced this issue Jan 6, 2020
@Svjard
fastify#57 - Fixed linting issues
a880682
mcollina pushed a commit that referenced this issue Jan 7, 2020
@Svjard @mcollina
#57 - Moved tests over to use fastify inject (#58)
8e91bc5 
* #57 - Moved tests over to use fastify inject

* #57 - Fixed linting issues

* Changed to use the new cookie parser from light-my-request

* Bumped the fastify dev dependency

* Unwrap listen calls in the tests
@jsumners
Copy link
Member Author

jsumners commented Jan 7, 2020

Resolved by #57.

@jsumners jsumners closed this as completed Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsumners