Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add schema version to drivers #174

Merged
merged 2 commits into from
Jul 17, 2023
Merged

add schema version to drivers #174

merged 2 commits into from
Jul 17, 2023

Conversation

fauna-chase
Copy link
Contributor

Leaving this as draft for now as the change to add the schema version hasn't made it out to prod yet.

ENG-5237
This builds on a change to core that started including the schema version in the query API response: https://github.com/fauna/core/blob/master/ext/api/src/main/resources/openapi.yml#L393 This schema version can be used by the dashboard to determine when it needs to refresh the schema. This includes both displaying schema to users as well as refreshing the environment used by the language library to provide intellisense.

macmv
macmv previously approved these changes Jul 10, 2023
Copy link
Contributor

@macmv macmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from formatting LGTM

__tests__/integration/schema-version.test.ts Outdated Show resolved Hide resolved
ENG-5237
This builds on a change to core that started including the schema version in the query API response:
https://github.com/fauna/core/blob/master/ext/api/src/main/resources/openapi.yml#L393
This schema version can be used by the dashboard to determine when it needs to refresh the schema.  This includes both displaying schema to users as well as refreshing the environment used by the language library to provide intellisense.
@fauna-chase fauna-chase marked this pull request as ready for review July 17, 2023 21:08
@fauna-chase fauna-chase merged commit 0d39ae6 into main Jul 17, 2023
4 checks passed
@fauna-chase fauna-chase deleted the schema-version branch July 17, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants