Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#188 - Fix double encoding bug (doubles being encoded as integers) #189

Merged
merged 2 commits into from
Jul 25, 2023
Merged

#188 - Fix double encoding bug (doubles being encoded as integers) #189

merged 2 commits into from
Jul 25, 2023

Conversation

cleve-fauna
Copy link
Contributor

@cleve-fauna cleve-fauna commented Jul 25, 2023 •
edited
Loading

#188

Problem

  • we are encoding some doubles as integers because we are relying on toString behavior to determine the type

Solution

Result

  • we properly encode doubles

Testing

  • created the new test, confirmed it fails on the original code and passes now

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cleve-fauna cleve-fauna changed the title main fixFloatingPointBug #188 - Fix double encoding bug (doubles being encoded as integers) Jul 25, 2023
@cleve-fauna cleve-fauna merged commit afc8275 into main Jul 25, 2023
4 checks passed
@cleve-fauna cleve-fauna deleted the main_fixFloatingPointBug branch July 25, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryfauna henryfauna henryfauna approved these changes

@ptpaterson ptpaterson Awaiting requested review from ptpaterson

@marrony marrony Awaiting requested review from marrony

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cleve-fauna @marrony @henryfauna