Accept undefined in setLastTxnTs input but treat it as a no-op. This resolves typescript compilation errors while maintaining current behavior #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleve-fauna
requested review from
ptpaterson,
cynicaljoy,
marrony and
henryfauna
cleve-fauna
force-pushed
the
main_tsError
branch
from
d0cc95e
to
e680a1b
Compare
…resolves typescript compilation errors while maintaining current behavior
cleve-fauna
force-pushed
the
main_tsError
branch
from
e680a1b
to
49c1c0a
Compare
cleve-fauna
commented
Aug 29, 2023
henryfauna
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): #199
Problem
We are producing invalid
client.d.tsfiles as the getter outputs different types for the setter for the fieldlastTxnTs.Solution
Accept the same types for input to the
lastTxnTssetter as are output from the getter. Maintain current behavior of the setter by ignoring undefined inputs (so users cannot break read their own write by passing in undefined here).Result
No more typescript errors.
Testing
Running regression tests via GitHub.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.