fix(api): remove all trailing dots (#95)

Current it only removes one trailing dot.
favonia · Oct 18, 2021 · f4ec041 · f4ec041
1 parent 342b7e8
commit f4ec041
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/api/fqdn.go b/internal/api/fqdn.go
@@ -52,7 +52,7 @@ func NewFQDN(domain string) (FQDN, error) {
 	normalized, err := profile.ToASCII(domain)
 
 	// Remove the final dot for consistency
-	normalized = strings.TrimSuffix(normalized, ".")
+	normalized = strings.TrimRight(normalized, ".")
 
 	return FQDN(normalized), err
 }

diff --git a/internal/api/fqdn_test.go b/internal/api/fqdn_test.go
@@ -111,7 +111,7 @@ func TestNewFQDN(t *testing.T) {
 		{"نامه\u200Cای.de", "xn--mgba3gch31f060k.de", true, ""},
 		// some other test cases
 		{"xn--a.xn--a.xn--a.com", "xn--a.xn--a.xn--a.com", false, "idna: invalid label \"\\u0080\""},
-		{"a.com...｡", "a.com...", true, ""},
+		{"a.com...｡", "a.com", true, ""},
 		{"..｡..a.com", "a.com", true, ""},
 	} {
 		tc := tc