Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): Add isVoidElement method #785

Merged
merged 1 commit into from
Apr 22, 2021
Merged

feat(parser): Add isVoidElement method #785

merged 1 commit into from
Apr 22, 2021

Conversation

fb55
Copy link
Owner

@fb55 fb55 commented Apr 22, 2021

Allows users to override this method and get custom void-element behavior.

Fixes #767

Allows users to override this method and get custom void-element behavior.

Fixes #767
@fb55
Copy link
Owner Author

fb55 commented Apr 22, 2021

@gilbert Please let me know if this matches your use-case!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 774320191

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 97.492%

Totals Coverage Status
Change from base Build 750994787: 0.005%
Covered Lines: 933
Relevant Lines: 957

💛 - Coveralls

@gilbert
Copy link

gilbert commented Apr 22, 2021

Looks great!

@fb55 fb55 merged commit 00ce57a into master Apr 22, 2021
@fb55 fb55 deleted the feat/void branch April 22, 2021 16:04
@vassudanagunta
Copy link
Contributor

vassudanagunta commented Jun 14, 2021

Looking forward to this being released soon. I don't need to override; my handler's onopentag needs to know whether the tag is a void element.

Thank you @fb55!

P.S. maybe declare isVoidElement as public?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for custom self-closing tags?
4 participants