automatically create new category when category in integrations is not found #11

fdarveau · 2021-09-18T15:17:49Z

No description provided.

…es labels is not found

fdarveau · 2021-09-18T16:56:06Z

Follow up to your comment in pawelmalak#7 : The way I first implemented the app categories for docker/kubernetes integrations assumed you already had categories set up before hand, which was my case since the integrations weren't in Flame when I initially forked it.

I have made a few changes to permanently add categories (they will be saved to the database, unlike docker/kubernetes apps) found in docker/kubernetes. If custom order is enabled, those categories will be added at the end, but can be re-ordered manually afterwards.

You can try those changes by using the create-docker-categories tag. Once you confirm it is working as you expect, I will merge this into the master branch and it will be available in the latest tag shortly afterwards.

NoLooseEnds · 2021-09-18T17:41:21Z

Thanks for the fast response! I just tested, but it seems like it treats every category as a new one – regardless if it's the same name or not.

…tions

fdarveau · 2021-09-18T17:56:51Z

The latest change should fix that for the next categories you add. You might have to force pull the new image since docker-compose doesn't always pick it up. I'm not sure about CLI, but if you are using Portainer, you can re-create the container manually :

Even with the old image, the extra categories should be gone once you refresh the page. You will also have to remove the extra "Download" categories manually, but they should not appear after a refresh since the apps they contain will all be grouped in the first "Download" category and categories without any apps are not shown.

NoLooseEnds · 2021-09-18T18:16:05Z

Yes, seems to work fine - without removing anything (I plan to do that, just because, but it was nice to test without).

In CLI you do: docker-compose pull docker-compose up (mostly with -d detached mode)

Thanks!

NoLooseEnds · 2021-09-18T18:44:10Z

I've finished moving all my containers into categories (I probably need to rethink some), but the default one "Docker" is still showing – even without any containers.

fdarveau · 2021-09-18T19:20:57Z

Can you try the new build?

Also, make sure you are on the home page, and not on "/applications", since that page always shows all categories, even if no pinned items are in it.

NoLooseEnds · 2021-09-18T19:24:12Z

I am on the home page, but unfortunately, it still shows a "Docker" category title, with no apps below.

fdarveau · 2021-09-18T23:02:54Z

The fix applied only to non-default categories. I have now applied it to non-default categories as well.

NoLooseEnds · 2021-09-19T10:47:34Z

Works. Thanks alot! :)

fdarveau · 2021-09-19T15:19:37Z

Good to hear!

This should be available in the latest tag in a few minutes.

…t found (#11) automatically create new category when category in docker or kubernetes labels is not found

christofkac · 2021-10-17T10:06:34Z

Hi,
I tried this container as I'm also interested in the categories for apps.
Unfortunately, pulling the fresh image does not work.
Here my results:

root@DS218plus:~# docker run -p 5446:5005 -v /volume1/docker/FlameNew:/app/data
ghcr.io/fdarveau/flame:latest
[2021-10-17 10:00:54.331 UTC+0] [INFO] Connected to database
[2021-10-17 10:00:54.638 UTC+0] [INFO] Executing pending migrations
[2021-10-17 10:00:57.256 UTC+0] [INFO] Socket: listen
[2021-10-17 10:00:57.257 UTC+0] [INFO] Server is running on port 5005 in production mode
[2021-10-17 10:01:13.277 UTC+0] [ERROR] SQLITE_ERROR: no such column: Category.type
[2021-10-17 10:01:13.292 UTC+0] [ERROR] SQLITE_ERROR: no such column: categoryId[2021-10-17 10:01:18.774 UTC+0] [ERROR] SQLITE_ERROR: no such column: isPinned
[2021-10-17 10:01:18.784 UTC+0] [ERROR] SQLITE_ERROR: no such column: categoryId

The output of the webpage is broken, too:

I would like to add the categories via the webpage and not the docker-file, not sure if this is the problem.

Any idea how to fix this?
Thanks!
Christof

fdarveau · 2021-10-17T21:24:24Z

If you used the same database as the original repository, can you try with a new one? If that works, there may be an issue with the migration from the original repository to my fork.

Also, there are currently some broken features in my fork, such as adding bookmarks / bookmark categories.

I don't have much time to investigate these problems in the following weeks, but I should be able to take a look into it by the end of November (sorry, I know that's a long time to wait for a fix).

christofkac · 2021-10-18T10:28:01Z

Thanks for the feedback.....I only don't fully understand what you mean with "new database" as I took your docker container, i.e. I would have expected that it contains the new database.
Can you point me at the thing I need to change?
Thanks!

fdarveau · 2021-10-18T11:34:04Z

The database is saved in the volume you specified, so it should be in /volume1/docker/FlameNew. If you used the same volume when (and if ) you used the original repository, it contains the original repository's database, which may be incompatible with my version.

To create a new database, you should either move/rename the database file in /volume1/docker/FlameNew or change the path in the docker run command (ex: docker run -p 5446:5005 -v /volume1/docker/FlameNew2:/app/data ghcr.io/fdarveau/flame:latest)

Desaydrone · 2021-10-23T06:15:24Z

Hello,

Got the same problem than @christofkac , i don't use the original container, and got this in the logs

flame    | [2021-10-23 05:51:09.497 UTC+0] [ERROR] SQLITE_ERROR: no such column: isPinned
flame    | [2021-10-23 05:51:09.502 UTC+0] [ERROR] SQLITE_ERROR: no such column: categoryId
flame    | [2021-10-23 05:51:31.034 UTC+0] [ERROR] SQLITE_ERROR: no such column: Category.type
flame    | [2021-10-23 05:51:31.037 UTC+0] [ERROR] SQLITE_ERROR: no such column: categoryId
flame    | [2021-10-23 05:51:42.058 UTC+0] [ERROR] SQLITE_ERROR: table categories has no column named type

Here are the sqlite database schema

CREATE TABLE `SequelizeMeta` (`name` VARCHAR(255) NOT NULL UNIQUE PRIMARY KEY);
CREATE TABLE `config` (`id` INTEGER PRIMARY KEY AUTOINCREMENT, `key` VARCHAR(255) NOT NULL UNIQUE, `value` VARCHAR(255) NOT NULL, `valueType` VARCHAR(255) NOT NULL, `isLocked` TINYINT DEFAULT 0, `createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL);
CREATE TABLE sqlite_sequence(name,seq);
CREATE TABLE `weather` (`id` INTEGER PRIMARY KEY AUTOINCREMENT, `externalLastUpdate` VARCHAR(255), `tempC` FLOAT, `tempF` FLOAT, `isDay` INTEGER, `cloud` INTEGER, `conditionText` TEXT, `conditionCode` INTEGER, `createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL);
CREATE TABLE `categories` (`id` INTEGER PRIMARY KEY AUTOINCREMENT, `name` VARCHAR(255) NOT NULL, `isPinned` TINYINT DEFAULT 0, `createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL, `orderId` INTEGER DEFAULT NULL);
CREATE TABLE `bookmarks` (`id` INTEGER PRIMARY KEY AUTOINCREMENT, `name` VARCHAR(255) NOT NULL, `url` VARCHAR(255) NOT NULL, `categoryId` INTEGER NOT NULL, `icon` VARCHAR(255) DEFAULT '', `createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL);
CREATE TABLE `apps` (`id` INTEGER PRIMARY KEY AUTOINCREMENT, `name` VARCHAR(255) NOT NULL, `url` VARCHAR(255) NOT NULL, `icon` VARCHAR(255) NOT NULL DEFAULT 'cancel', `isPinned` TINYINT DEFAULT 0, `createdAt` DATETIME NOT NULL, `updatedAt` DATETIME NOT NULL, `orderId` INTEGER DEFAULT NULL);

and this is my docker compose file

version: '2.1'
services:
  flame:
    image: ghcr.io/fdarveau/flame:latest
    container_name: flame
    volumes:
      - /home/me/docker_compose/flame/data_flame:/app/data
    ports:
      - 80:5005
    restart: unless-stopped

Did i miss something in my conf ?

fdarveau · 2021-12-07T03:48:22Z

I started working on updating this fork with the latest changes up to v2.1.1.

Since there are a ton of changes, including some changes that I had implemented in this fork such as ordering bookmarks, I basically started from scratch to make it easier to maintain on my side by using pawelmalak's code instead of mine for those features.

You can check the progress in #12 and you can pull ghcr.io/fdarveau/flame:merge_upstream_2-1-1 to test it out. IMPORTANT : I have not fully tested that version. There may still be bugs, but the basic features (such as managing apps/bookmarks) seems to work well.

Also, I noticed the Issues section of the repository was disabled, so I enabled it for future issues users encounter with this fork.

fdarveau · 2021-12-10T18:24:16Z

@christofkac @Desaydrone I finished updating this fork to the latest version and everything seems to work fine on my end.

If you still need this application, can you give it a try? If you encounter any problem, you can open a new issue to discuss specific problems.

Note that there are some breaking changes which require deleting/renaming the database file, as described in the updated README : https://github.com/fdarveau/flame#important-update-2021-12-10.

christofkac · 2021-12-10T21:51:13Z

Hi,
I used the latest version from docker and it works fine.
Now the only issue is, that I can't define any category for apps - I thought this was part of your rework, isn't it?
I used the latest container from 2021-12-02 17:02:27.
The version pawelmalak/flame:dev-alpha2 seems to not work at all, in the log I see only
standard_init_linux.go:228: exec user process caused: exec format error
Any hints?
Thanks
Christof

NoLooseEnds · 2021-12-10T21:56:21Z

Pulled the :latest image, and it works fine. I started with a new db and config. Enabled docker api and presto; all is back, categories and all.

fdarveau · 2021-12-10T22:04:40Z

Hi,
I used the latest version from docker and it works fine.
Now the only issue is, that I can't define any category for apps - I thought this was part of your rework, isn't it?
I used the latest container from 2021-12-02 17:02:27.
The version pawelmalak/flame:dev-alpha2 seems to not work at all, in the log I see only
standard_init_linux.go:228: exec user process caused: exec format error
Any hints?
Thanks
Christof

If you are using images from pawelmalak, you will have to open issues in his repository.

If you want to try or need features from my fork (such as app categories), you should use ghcr.io/fdarveau/flame:latest

Desaydrone · 2021-12-11T02:49:50Z

Hi,

I works fine for me now, i can create category for apps. Awesome job, thanks a lot !!

christofkac · 2021-12-11T21:55:08Z

Hi,
my bad, I lost track of the repositories ;-)
I created a container with the following compose file:

version: '3.6'

services:
  flame:
    image: ghcr.io/fdarveau/flame:latest
    hostname: flame
    container_name: flame
    volumes:
      - flame-data:/app/data
    ports:
      - 5005:5005
    environment:
      TZ: Europe/Berlin
    restart: unless-stopped
    network_mode: bridge

# Explicitly define the persistent volume for your data storage
volumes:
  flame-data:

Container starts, but when I click on /apps, I get simply a black screen.
/bookmarks works as expected

I also deleted the persistent volume from my previous installation, so there should not be any left overs.
Any idea?
Thanks
Christof

christofkac · 2021-12-11T22:07:58Z

I tired on another server to create the container from ghcr.io/fdarveau/flame:latest with the same result.
I logged in and when I click on /app, only a black screen is visible.

Any help is appreciated.
Bye
Christof

NoLooseEnds · 2021-12-11T23:26:38Z

What does the logs say?

fdarveau · 2021-12-12T04:19:30Z

I logged in and when I click on /app, only a black screen is visible.

@christofkac Found the issue. I accidentally changed one of the links to the applications page to /apps instead of /applications. It is now fixed in the latest tag.

I also added a new "Not found" page to handle that kind of error more gracefully, with a link to the homepage that makes the app work again instead of always being a blank page.

If you encounter any other problem, please open a new issue to make things easier to track.

christofkac · 2021-12-12T10:41:48Z

Cool, works. Thanks.
I like your solution as it is very lightweight.....

fdarveau added 3 commits September 18, 2021 11:16

automatically create new category when category in docker or kubernet…

cd10074

…es labels is not found

fix assignment to const variable

78f3260

get categories after apps retrieved to include integration categories

12b21d6

add category created by integration to categories list for next itera…

2eb7a76

…tions

only show categories with pinned items

29e230c

apply previous fix to default categories

efe8ad0

fdarveau merged commit 5abe779 into master Sep 19, 2021

fdarveau deleted the create-docker-categories branch September 19, 2021 15:21

fdarveau added a commit that referenced this pull request Oct 11, 2021

automatically create new category when category in integrations is no…

349d63c

…t found (#11) automatically create new category when category in docker or kubernetes labels is not found

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

automatically create new category when category in integrations is not found #11

automatically create new category when category in integrations is not found #11

fdarveau commented Sep 18, 2021

fdarveau commented Sep 18, 2021

NoLooseEnds commented Sep 18, 2021

fdarveau commented Sep 18, 2021

NoLooseEnds commented Sep 18, 2021

NoLooseEnds commented Sep 18, 2021

fdarveau commented Sep 18, 2021

NoLooseEnds commented Sep 18, 2021

fdarveau commented Sep 18, 2021 •

edited

Loading

NoLooseEnds commented Sep 19, 2021

fdarveau commented Sep 19, 2021 •

edited

Loading

christofkac commented Oct 17, 2021 •

edited

Loading

fdarveau commented Oct 17, 2021

christofkac commented Oct 18, 2021

fdarveau commented Oct 18, 2021

Desaydrone commented Oct 23, 2021 •

edited

Loading

fdarveau commented Dec 7, 2021 •

edited

Loading

fdarveau commented Dec 10, 2021 •

edited

Loading

christofkac commented Dec 10, 2021

NoLooseEnds commented Dec 10, 2021

fdarveau commented Dec 10, 2021

Desaydrone commented Dec 11, 2021

christofkac commented Dec 11, 2021

christofkac commented Dec 11, 2021

NoLooseEnds commented Dec 11, 2021

fdarveau commented Dec 12, 2021

christofkac commented Dec 12, 2021

automatically create new category when category in integrations is not found #11

automatically create new category when category in integrations is not found #11

Conversation

fdarveau commented Sep 18, 2021

fdarveau commented Sep 18, 2021

NoLooseEnds commented Sep 18, 2021

fdarveau commented Sep 18, 2021

NoLooseEnds commented Sep 18, 2021

NoLooseEnds commented Sep 18, 2021

fdarveau commented Sep 18, 2021

NoLooseEnds commented Sep 18, 2021

fdarveau commented Sep 18, 2021 • edited Loading

NoLooseEnds commented Sep 19, 2021

fdarveau commented Sep 19, 2021 • edited Loading

christofkac commented Oct 17, 2021 • edited Loading

fdarveau commented Oct 17, 2021

christofkac commented Oct 18, 2021

fdarveau commented Oct 18, 2021

Desaydrone commented Oct 23, 2021 • edited Loading

fdarveau commented Dec 7, 2021 • edited Loading

fdarveau commented Dec 10, 2021 • edited Loading

christofkac commented Dec 10, 2021

NoLooseEnds commented Dec 10, 2021

fdarveau commented Dec 10, 2021

Desaydrone commented Dec 11, 2021

christofkac commented Dec 11, 2021

christofkac commented Dec 11, 2021

NoLooseEnds commented Dec 11, 2021

fdarveau commented Dec 12, 2021

christofkac commented Dec 12, 2021

fdarveau commented Sep 18, 2021 •

edited

Loading

fdarveau commented Sep 19, 2021 •

edited

Loading

christofkac commented Oct 17, 2021 •

edited

Loading

Desaydrone commented Oct 23, 2021 •

edited

Loading

fdarveau commented Dec 7, 2021 •

edited

Loading

fdarveau commented Dec 10, 2021 •

edited

Loading