Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added animation for Recycler View. #834

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ChaitanyaMunje
Copy link

@ChaitanyaMunje ChaitanyaMunje commented Aug 19, 2021

Added slide from left to right animation to the Recycler View to improve user experience.
Below is the link for GIF to view the animation added in the application.
https://media.geeksforgeeks.org/wp-content/uploads/20210819123440/20210819122501.gif

@federicoiosue
Copy link
Owner

Hi there,

This feature was already present into the some time ago but was been removed due to incongruence with material guidelines.

You've done a great work and this feature could be added again but it should also be added an option to enable/disable it (with "disabled" as default, to follow guidelines: no unrequired animations) into the Settings->Interface section.

@federicoiosue federicoiosue self-requested a review August 22, 2021 09:35
@ChaitanyaMunje
Copy link
Author

Ok sure I will add an option to enable/ disable this animation in settings screen. In this animation I will set the default animation as disabled.

Copy link
Owner

@federicoiosue federicoiosue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to update the change request once modified settings to include the option to enable/disable the animation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants