Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should all the greenboot-* systemd services be enabled? #91

Closed
alcir opened this issue Jan 1, 2023 · 8 comments
Closed

Should all the greenboot-* systemd services be enabled? #91

alcir opened this issue Jan 1, 2023 · 8 comments

Comments

@alcir
Copy link
Contributor

alcir commented Jan 1, 2023

Unless greenboot is enabled by default in your distribution, enable it by running `systemctl enable greenboot-task-runner greenboot-healthcheck greenboot-status greenboot-loading-message`.

Do greenboot-rpm-ostree-grub2-check-fallback greenboot-grub2-set-counter redboot-task-runner redboot-auto-reboot should be enabled as well?

@7flying
Copy link
Member

7flying commented Jan 5, 2023

No, those are only triggered when a health check fails and handle the reboot/rollback of your system.

@alcir
Copy link
Contributor Author

alcir commented Jan 5, 2023

mmm, are you sure? Because if I leave them disabled (I was performing some test on Fedora Silverblue), greenboot doesn't work as described.
In addition, on Fedora IoT (if I'm not wrong) these services seem to be enabled.

@nullr0ute
Copy link
Member

mmm, are you sure? Because if I leave them disabled (I was performing some test on Fedora Silverblue), greenboot doesn't work as described. In addition, on Fedora IoT (if I'm not wrong) these services seem to be enabled.

Because IoT enables them in the IoT presets: /usr/lib/systemd/system-preset/80-iot.preset

@alcir
Copy link
Contributor Author

alcir commented Jan 5, 2023

Because IoT enables them in the IoT presets: /usr/lib/systemd/system-preset/80-iot.preset

So in a system without such presets, they should be manually enabled?

@nullr0ute
Copy link
Member

Because IoT enables them in the IoT presets: /usr/lib/systemd/system-preset/80-iot.preset

So in a system without such presets, they should be manually enabled?

Not all, just the ones specified in the presets.

@alcir
Copy link
Contributor Author

alcir commented Jan 5, 2023

Yes.
Looking at /usr/lib/systemd/system-preset/80-iot.preset, what I mean in this issue is: in the readme, in addition to greenboot-task-runner greenboot-healthcheck greenboot-status greenboot-loading-message also greenboot-rpm-ostree-grub2-check-fallback greenboot-grub2-set-counter redboot-task-runner redboot-auto-reboot should be added. Isn't it?

@LorbusChris
Copy link
Member

@alcir all the greenboot-* services present in 80-iot.preset should be added to the README for completeness. Feel free to open a PR.

It does looks like greenboot-loading-message.service is not currently enabled in the preset file. I'm not sure whether that's intended or an oversight, in which case it should probably be added to the preset.

@alcir alcir mentioned this issue Jan 20, 2023
nullr0ute pushed a commit that referenced this issue Jan 20, 2023
Enable other services, as per 80-iot.preset
#91
@alcir
Copy link
Contributor Author

alcir commented Jan 20, 2023

It does looks like greenboot-loading-message.service is not currently enabled in the preset file. I'm not sure whether that's intended or an oversight, in which case it should probably be added to the preset.

https://src.fedoraproject.org/rpms/fedora-release/pull-request/245

Thank you all.

@alcir alcir closed this as completed Jan 20, 2023
qinqon pushed a commit to qinqon/rpms-fedora-release that referenced this issue Mar 16, 2023
Enable greenboot-loading-message.service as per fedora-iot/greenboot#91 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants