-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swapper changes #257
swapper changes #257
Conversation
Looks good except that e2e tests are failing. |
test/integration/tests/buybacks.ts
Outdated
@@ -42,7 +42,7 @@ describe('e2e-buybacks', function () { | |||
doLogging && console.log(`Environment loaded.`); | |||
}); | |||
|
|||
describe('PCV Equity Minter + LBP', async function () { | |||
describe.only('PCV Equity Minter + LBP', async function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove .only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
From auditor feedback, add exitPool and withdrawERC20 functionality, as well as make the min token a requirement.
Also:
TODO: