FIP-55: PCV Guardian

contract-addresses/permissions.json

@@ -24,10 +24,12 @@
     "feiDAOTimelock",
     "ratioPCVController",
     "aaveEthPCVDripController",
-    "compoundEthPCVDripController"
+    "compoundEthPCVDripController",
+    "pcvGuardian"
   ],
   "GUARDIAN_ROLE": [
-    "multisig"
+    "multisig",
+    "pcvGuardian"
   ],
   "ORACLE_ADMIN_ROLE" : [
     "collateralizationOracleGuardian",

proposals/dao/fip_55.ts

@@ -0,0 +1,62 @@
+import { ethers } from 'hardhat';
+import chai, { expect } from 'chai';
+import CBN from 'chai-bn';
+import {
+  DeployUpgradeFunc,
+  NamedContracts,
+  SetupUpgradeFunc,
+  TeardownUpgradeFunc,
+  ValidateUpgradeFunc
+} from '../../types/types';
+import { PCVGuardian } from '@custom-types/contracts';
+
+chai.use(CBN(ethers.BigNumber));
+
+/*
+PCV Guardian
+
+DEPLOY ACTIONS:
+
+1. Deploy PCV Guardian
+
+DAO ACTIONS:
+1. Grant PCV Guardian GUARDIAN_ROLE
+2. Grant PCV Guardian PCV_CONTROLLER_ROLE
+
+*/
+
+export const deploy: DeployUpgradeFunc = async (deployAddress, addresses, logging = false) => {
+  const { core, feiDAOTimelock, compoundEthPCVDeposit, ethReserveStabilizer, aaveEthPCVDeposit } = addresses;
+
+  if (!core) {
+    throw new Error('An environment variable contract address is not set');
+  }
+
+  // 1. Deploy PCV Guardian
+  const factory = await ethers.getContractFactory('PCVGuardian');
+  const safeAddresses = [feiDAOTimelock, compoundEthPCVDeposit, ethReserveStabilizer, aaveEthPCVDeposit];
+  const pcvGuardian = await factory.deploy(core, safeAddresses);
+
+  await pcvGuardian.deployTransaction.wait();
+
+  logging && console.log('pcvGuardian: ', pcvGuardian.address);
+
+  return {
+    pcvGuardian
+  } as NamedContracts;
+};
+
+export const setup: SetupUpgradeFunc = async (addresses, oldContracts, contracts, logging) => {
+  logging && console.log('No setup');
+};
+
+export const teardown: TeardownUpgradeFunc = async (addresses, oldContracts, contracts, logging) => {
+  logging && console.log('No teardown');
+};
+
+export const validate: ValidateUpgradeFunc = async (addresses, oldContracts, contracts) => {
+  const pcvGuardian: PCVGuardian = contracts.pcvGuardian as PCVGuardian;
+
+  const safeAddresses = await pcvGuardian.getSafeAddresses();
+  expect(safeAddresses.length).to.be.equal(4);
+};

proposals/description/fip_55.ts

@@ -0,0 +1,31 @@
+import { ProposalDescription } from '@custom-types/types';
+
+const fip_55: ProposalDescription = {
+  title: 'FIP-55: PCV Guardian',
+  commands: [
+    {
+      target: 'core',
+      values: '0',
+      method: 'grantGuardian(address)',
+      arguments: ['{pcvGuardian}'],
+      description: 'Grant PCV Guardian GUARDIAN_ROLE'
+    },
+    {
+      target: 'core',
+      values: '0',
+      method: 'grantPCVController(address)',
+      arguments: ['{pcvGuardian}'],
+      description: 'Grant PCV Guardian PCV_CONTROLLER_ROLE'
+    }
+  ],
+  description: `
+  Create a PCV Guardian which can move PCV only to safe locations, namely other PCV deposits that are particularly low risk.
+
+  This would help save assets in the event of a hack or extreme market conditions if Fei Protocol has a heads up.
+
+  Code: https://github.com/fei-protocol/fei-protocol-core/pull/353
+  Discussion: https://tribe.fei.money/t/fip-55-pcv-guardian/3744 
+`
+};
+
+export default fip_55;

test/integration/proposals_config.ts

@@ -2,7 +2,7 @@ import { ProposalsConfigMap } from '@custom-types/types';
 
 // import fip_xx_proposal from '@proposals/description/fip_xx';
 
-import permanently_revoke_burner_proposal from '@proposals/description/permanently_revoke_burner';
+import fip_55_proposal from '@proposals/description/fip_55';
 
 const proposals: ProposalsConfigMap = {
   /*
@@ -13,11 +13,11 @@ const proposals: ProposalsConfigMap = {
         proposal: fip_xx_proposal // full proposal file, imported from '@proposals/description/fip_xx.ts'
     }
     */
-  permanently_revoke_burner: {
+  fip_55: {
     deploy: true,
     skipDAO: false,
     totalValue: 0,
-    proposal: permanently_revoke_burner_proposal
+    proposal: fip_55_proposal
   }
 };