Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named Static Cached PCVDeposit #379
Named Static Cached PCVDeposit #379
Changes from 36 commits
d298cf4
de0d342
c1e490a
746840c
945476c
26e62a9
efaf3ee
4936255
d1a756e
a628eb0
9522a0e
6653a45
165e4b8
9488d11
3c7b19f
5b50e87
8ac6652
cff5867
63f14b6
b05a289
013e6dd
5151e86
0ce4a81
a5c23df
dc45987
603af7c
8b9eaaf
ae3597f
c57436b
45cebc7
2e4cc64
d01a8f5
7bc3475
cdd77f0
77a8290
57351b6
34c5af3
d6709a5
267f4b4
8c74f52
e7867a5
e0f620a
3c90927
5e14be2
8310953
0b12fa6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we store a mapping of names -> DepositInfo for lookups? Can also be used to ensure that no duplicate names are added to @ditchfieldcaleb 's earlier concerns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need to think adversarially about deposit names as only OA and the governor can update the list and guardian can remove deposits instantly.
If we were to do this feature, the data structure would be name -> DepositInfo Index so that we aren't storing each struct and it's data twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use oldBalance and oldFeiBalance to save another sload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added