Re-enable buybacks #390
Merged
Re-enable buybacks #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of 1->99 that created a lot of slippage
v2 proposal has already been executed onchain
Joeysantoro
requested changes
Dec 20, 2021
|
|
||
| const txReceipt = await tx.wait(); | ||
| const { logs: rawLogs } = txReceipt; | ||
| const noFeeFeiTribeLBPAddress = `0x${rawLogs[rawLogs.length - 1].topics[1].slice(-40)}`; |
There was a problem hiding this comment.
this code will never die ;)
Joeysantoro
previously approved these changes
Dec 21, 2021
|
|
||
| export const validate: ValidateUpgradeFunc = async (addresses, oldContracts, contracts) => { | ||
| // pcvEquityMinter should target the new LBPSwapper | ||
| expect(await contracts.pcvEquityMinter.target()).to.be.equal(addresses.noFeeFeiTribeLBPSwapper); |
There was a problem hiding this comment.
prefer to pull this variable out of the address object for readability
There was a problem hiding this comment.
I like to use contracts.* and addresses.* for readability actually
|
|
||
| // No tokens should remain anywhere on our contracts | ||
| expect(await contracts.fei.balanceOf(addresses.feiTribeLBPSwapper)).to.be.equal('0'); | ||
| expect(await contracts.tribe.balanceOf(addresses.feiTribeLBPSwapper)).to.be.equal('0'); |
There was a problem hiding this comment.
same comment as above. prefer to pull out of the address object for readability
eswak
force-pushed
the
feat/buyback_newpool
branch
from
9ef5a9c
to
9144dd1
Compare
Joeysantoro
previously approved these changes
Dec 24, 2021
Joeysantoro
approved these changes
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable buybacks
Last week, we had to use the Guardian to pause the buybacks. This proposal re-enables buybacks.
Also updates the LBPSwapper to shift weights from 95% -> 5%, instead of 99% -> 1%.
Proposal calldata :