Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type addressess #398

Merged
merged 14 commits into from
Dec 21, 2021
Merged

type addressess #398

merged 14 commits into from
Dec 21, 2021

Conversation

Joeysantoro
Copy link
Contributor

@Joeysantoro Joeysantoro commented Dec 20, 2021

Typing the mainnetAddresses.ts accomplishes 2 goals:

  1. Allow for filtering and grouping when auto-generating documentation
  2. Allow group exclusions on integration tests such as dependencies file

kryptoklob
kryptoklob previously approved these changes Dec 21, 2021
ElliotFriedman
ElliotFriedman previously approved these changes Dec 21, 2021
Copy link
Contributor

@ElliotFriedman ElliotFriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ElliotFriedman ElliotFriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ElliotFriedman ElliotFriedman merged commit b9cae86 into develop Dec 21, 2021
@Joeysantoro Joeysantoro deleted the feat/address-type branch December 25, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants