-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecated test #423
deprecated test #423
Conversation
@@ -23,7 +23,17 @@ describe('e2e-dependencies', function () { | |||
for (let j = 0; j < contracts.length; j++) { | |||
const contract = contracts[j]; | |||
const category = addresses[contract].category; | |||
if (category === 'External' || category === 'Deprecated') { | |||
if (category === 'External') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should make an enum for these categories in the types file and import it here instead of using string literals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and also probably use said enum everywhere else if you can do that without manually editing 500+ lines of code)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it already was an enum. Used it here
} | ||
} | ||
}); | ||
|
||
it('all dependencies bidirectional', async function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this wasn't an edit on this pr but the string "Check dependencies all dependencies bidirectional" doesn't tell me what it's checking, maybe something like "Check dependencies are listed bidirectionally" would?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed this and others
…rotocol-core into feat/deprecated-check
Adds deprecated contracts signoff category for proposals_config.
Adds an integration test to require that these contracts are in fact deprecated and not contained anywhere in dependencies map