FIP-60 - Fuse guardian #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kryptoklob
reviewed
Jan 3, 2022
ElliotFriedman
previously requested changes
Jan 4, 2022
contracts/feirari/FuseGuardian.sol
Outdated
| comptroller._setMarketSupplyCaps(cTokens, newSupplyCaps); | ||
| } | ||
|
|
||
| function _setMarketSupplyCapsByUnderlying(address[] calldata underlyings, uint[] calldata newSupplyCaps) external { |
There was a problem hiding this comment.
I don't like how this function calls a public function that has a modifier on it and has no modifier on itself in the function signature. It obfuscates who is allowed to call it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a Fuse pause/borrow cap admin wrapper which gives access to Guardian and TribalChiefAdmins the ability to pause pools and set caps.
It also includes a utility for pausing/capping by underlying rather than the cToken. This is important because the cToken address cannot be pre-computed so this feature allows atomic deployment/pausing/capping.