Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style Cleanup #54

Merged
merged 1 commit into from
Feb 7, 2021
Merged

Style Cleanup #54

merged 1 commit into from
Feb 7, 2021

Conversation

Joeysantoro
Copy link
Contributor

Resolves OZ audit issues N06, N29

Decided not to update any style discrepancies in dao to keep changes to forked code to a minimum

Summary:

  • ran VSCode format on all contract files except mock and dao (this made uint->uint256 happen)
  • Enforced internal functions begin with _ convention
  • Ran solhint and added ignore on relevant areas
  • made _feiTribeExchangeRate internal

@Joeysantoro Joeysantoro changed the base branch from master to POZ-Fixes February 7, 2021 18:41
@Joeysantoro Joeysantoro added the OZ Fix New A PR dedicated to fix an OpenZeppelin issue label Feb 7, 2021
@Joeysantoro Joeysantoro merged commit c1eecbe into POZ-Fixes Feb 7, 2021
Joeysantoro added a commit that referenced this pull request Jul 19, 2021
@Joeysantoro
Merge pull request #54 from fei-protocol/OZ-Audit-New-M04
f5b6b52 
safe ERC20
@kryptoklob kryptoklob deleted the POZ-Style-Cleanup branch September 19, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OZ Fix New A PR dedicated to fix an OpenZeppelin issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Joeysantoro