Fei/Volt Swap #719
Merged
Fei/Volt Swap #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kryptoklob
reviewed
Apr 21, 2022
Joeysantoro
reviewed
Apr 21, 2022
Comment on lines
1594
to
1598
| voltFusePCVDeposit: { | ||
| artifactName: 'ERC20CompoundPCVDeposit', | ||
| address: '0xFeBDf448C8484834bb399d930d7E1bdC773E23bA', | ||
| category: AddressCategory.PCV | ||
| }, |
There was a problem hiding this comment.
Tbh I don't love the intermingling here. Lets think about having a parallel mainnetAddresses configuration in volt or even rewriting the proposal flow in forge
There was a problem hiding this comment.
I already did a simulation in the volt repo with forge, but it's not the same thing as writing out the calldata steps here. https://github.com/volt-protocol/volt-protocol-core/pull/70/files
Joeysantoro
reviewed
Apr 21, 2022
kryptoklob
previously approved these changes
Apr 25, 2022
kryptoklob
approved these changes
Apr 25, 2022
| export const deploy: DeployUpgradeFunc = async (deployAddress, addresses, logging = false) => { | ||
| const TOKEN_DEPOSIT = process.env.TOKEN_DEPOSIT; | ||
| const TOKEN = process.env.TOKEN; | ||
| const IS_PROTOCOL_FEI_DEPOSIT = |
There was a problem hiding this comment.
I don't like adding new env vars that need to be set for deployment scripts that will be re-used; this is fine for now but in the future I want to move to hardhat tasks so that we can pass in these parameters via CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAO Steps:
to the VOLT PCV Deposit so that the funds do not get invested into fuse
will be reflected in the PCV