Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contract admin cleanup #789

Merged
merged 2 commits into from
May 10, 2022
Merged

contract admin cleanup #789

merged 2 commits into from
May 10, 2022

Conversation

Joeysantoro
Copy link
Contributor

No description provided.

@Joeysantoro Joeysantoro requested a review from a team as a code owner May 10, 2022 00:40
thomas-waite
thomas-waite reviewed May 10, 2022
View reviewed changes
Copy link
Contributor

@thomas-waite thomas-waite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do we also want to deploy this contract and deprecate the old one? We could make a TC proposal to do it

@Joeysantoro
Copy link
Contributor Author

Looks good to me. Do we also want to deploy this contract and deprecate the old one? We could make a TC proposal to do it

I don't think this is necessary. It doesn't change anything practically

@Joeysantoro Joeysantoro merged commit 5f2fd2a into develop May 10, 2022
@Joeysantoro Joeysantoro deleted the feat/contractAdminCleanup branch May 10, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-waite thomas-waite thomas-waite left review comments

@kryptoklob kryptoklob kryptoklob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joeysantoro @kryptoklob @thomas-waite