CR Oracle + Timelock Ops #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EDIT: deleted old calldata |
kryptoklob
previously approved these changes
Jun 22, 2022
proposals/dao/timelock_admin.ts
Outdated
| // Run any validations required on the fip using mocha or console logging | ||
| // IE check balances, check state of contracts, etc. | ||
| const validate: ValidateUpgradeFunc = async (addresses, oldContracts, contracts, logging) => { | ||
| console.log('here'); |
There was a problem hiding this comment.
Nit: Remove this console.log
proposals/dao/timelock_admin.ts
Outdated
| // This should exclusively include new contract deployments | ||
| const deploy: DeployUpgradeFunc = async (deployAddress: string, addresses: NamedAddresses, logging: boolean) => { | ||
| const factory = (await hre.ethers.getContractFactory('ERC20PCVDepositWrapper')) as ERC20PCVDepositWrapper__factory; | ||
| const rariTimelockFeiOldLens = await factory.deploy(addresses.rariInfraFeiTimelock, addresses.fei, true); |
There was a problem hiding this comment.
Will make sure to add lenses for contracts with significant Fei that are becoming part of the Fei ecosystem in the future!
| import { TemplatedProposalDescription } from '@custom-types/types'; | ||
|
|
||
| const timelock_admin: TemplatedProposalDescription = { | ||
| title: 'Timelock Updates', |
There was a problem hiding this comment.
Would probably add a TIP number?
|
|
||
| const proposals: TemplatedProposalsConfigMap = { | ||
| tip_111: { | ||
| // tip_111: { |
There was a problem hiding this comment.
Think this is leftover commenting and needs deleting? tokemak_withdraw and tip_112 can both be removed.
pod_exec_v2 needs to stay here, it hasn't been proposed/executed by the TC yet
Joeysantoro
commented
Jun 22, 2022
|
|
||
| // Increase PCV balance to exceed deviation threshold | ||
| const pcvStats = await collateralizationOracleWrapper.pcvStats(); | ||
| await namedStaticPCVDepositWrapper.addDeposit({ |
There was a problem hiding this comment.
this test relies on named static PCV deposit which will be deprecated in this proposal. Erwan's #923 also deprecates the keeper
| values: '0', | ||
| method: 'grantRole(bytes32,address)', | ||
| arguments: (addresses) => [ | ||
| '0x471cfe1a44bf1b786db7d7104d51e6728ed7b90a35394ad7cc424adf8ed16816', // SWAP_ADMIN_ROLE |
There was a problem hiding this comment.
Nit, you can import ethers now and replace this with ethers.utils.id('SWAP_ADMIN_ROLE)
| @@ -47,6 +52,9 @@ const validate: ValidateUpgradeFunc = async (addresses, oldContracts, contracts, | |||
| expect(await contracts.rariTimelockFeiOldLens.balanceReportedIn()).to.be.equal(addresses.fei); | |||
| expect(await contracts.tribalCouncilTimelockFeiLens.balanceReportedIn()).to.be.equal(addresses.fei); | |||
| expect(await contracts.namedStaticPCVDepositWrapper.numDeposits()).to.be.equal('0'); | |||
| expect(await contracts.ethToDaiLBPSwapper.swapEndTime()).to.be.gt( | |||
| ethers.BigNumber.from((await time.latest()).toString()) | |||
| ); | |||
There was a problem hiding this comment.
Depends how confident are, but I would probably make sure you can do a swap via the LBP pool here
| false, | ||
| false | ||
| ], | ||
| description: 'Withdraw 10k ETH to LBP Swapper' |
There was a problem hiding this comment.
Weights are 95 / 5 . You're sending $1m DAI and ~$10.5m ETH. So overfunding by $500k, should be fine
|
Calldata: Execute Calldata: |
thomas-waite
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type: Feature
PR Description:
Executes a few cleanup actions related to collateralization and operations:
PR Checklist - Feature (Proposal)