Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ftrim() command to the client #54

Merged
merged 1 commit into from
Jun 7, 2013

Conversation

eschnou
Copy link
Collaborator

@eschnou eschnou commented Jun 5, 2013

This command sets a reference of the horizontal plane for the drone internal control system.
Relates to issue #27

}

var self = this;
console.log("Stabilizing…")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lib shouldn't do logging like this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki, I'll remove this line. You should have a look at Client.js, I added a few log statements wrt tcp reconnection in there when refactored the getVideo/getPng stuff. Happy to change to whatever you prefer.

This command sets a reference of the horizontal plane
for the drone internal control system.

Relates to felixge#27
eschnou added a commit that referenced this pull request Jun 7, 2013
Added ftrim() command to the client.
@eschnou eschnou merged commit 05e4029 into felixge:master Jun 7, 2013
@eschnou
Copy link
Collaborator Author

eschnou commented Jun 7, 2013

Updated following our discussion and merged. If any issues remaining, ping me and I'm happy to fix.

@eschnou eschnou deleted the feature_ftrim branch June 7, 2013 19:52
@felixge
Copy link
Owner

felixge commented Jun 7, 2013

💖 awesome - thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants