Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mouse selection #62

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Fix mouse selection #62

merged 3 commits into from
Apr 8, 2024

Conversation

fernandotonon
Copy link
Owner

Summary

Fixed selecting items and raycast from screen, also camera aspect ratio when it is in portrait mode

Technical Details

  • Workarounded the selection by adding a division by 2 in the width and height in the TransformOperator
  • Added tests for TransformOperator
  • fixed the aspect ratio by removing the logic that set it to 1 for portrait mode.

✨ Features

  • none

🐛 Bugfixes

  • Fix selecting items
  • Camera aspect ratio in portrait mode

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@fernandotonon fernandotonon merged commit 4b2dc95 into master Apr 8, 2024
10 of 11 checks passed
@fernandotonon fernandotonon deleted the improvements8 branch April 8, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fernandotonon