New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix locale customization not being applied when using `locale.locale` + fix locale custom format not being applied on display label #552

Open

jmira-dojo wants to merge 4 commits into fetrarij:master from jmira-dojo:master

jmira-dojo commented Jul 15, 2024

this pull request addresses two issues:

locale customization is not being applied when locale.locale is used

customization_not_acknowledged.webm

when format or displayFormat is defined, it is not applied when calculating chosenLabel

formatting_not_using_locale.webm

with the fixes included in this pull request

with_customization_and_locale_formatting.webm

jmira-dojo added 4 commits

July 11, 2024 16:55


          locale customization is also applied when using a locale.locale

a7f5856


          chosenLabel should use locale, if present

3e12368


          add extra options to locale demo

3b8b04e


          cleanup building of chosenLabel

0713a9f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet