-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package extension #292
Comments
Zip works locally as per commit 803cefe |
Firefox: done \o/ |
Packaging task and local upload works for Chromium. |
IMHO starting an Edge version is probably too much, since it'll switch to Blink soon. What's your opinion, @notabene ? And FWIW, I'll try to improve UI too before release new version on stores. |
Yes, let's remove Edge.
|
@ffoodd shouldn't this issue be closed if you're OK with Chrome? (can't test it, don't have it, don't want it) ;) |
@notabene Still need to check storage (don't really know what to check) and to publish on store. I'll finish #325 + try to close ffoodd/a11y.css-webextension#13 (or document it), then improve UI a bit before releasing it to Chrome add-on webstore: that'll make (IMHO) the first milestone for webextension, meaning that I'll merge it to So before it's done:
|
@notabene I just published a 1.0.6 on firefox add-ons (and currently waiting for approval on chrome's webstore). I’d like you to test a bit before definetely merging this first version on master, and recommending it as the main a11y.css usage on the wiki + website :) I may have missed something… |
Not good. As I told you the other day, I haven't found yet how to store a state when going from one tab to another. Your evolution does not work as expected. Steps to reproduce:
If you look into the Web Developer extension you'll see the same problem. I'm not sure an extension has the right to access a tab when you switch back to it. I'd suggest keeping to the old method for now, and getting rid of the switch boxes. |
@notabene Hii thanks for checking in! I just pushed something: I managed to use storage for each setting, and it's working in both Firefox and Chromium. It's not done yet:
FWIW we're getting closer and closer to a first fully working version, and that's nice! |
Maybe @GaetanBt could help a bit? |
After some tries, I managed to get the current tab id with @notabene code part in browser.tabs.query({ active: true, currentWindow: true }).then((tabs) => {
console.log(tabs[0].id);
}); I don't know if I'll be able to make a helper for this, since Let's try by repeating this for now. The only part missing now is to use this to contextually store states and values for a specific tab, and prevent a tab's values from override another one's. |
@notabene I just pushed a 1.0.7 to Firefox add-ons, that correctly handle tab specific storage in Firefox. However this does not work on Chromium for now, and I have no idea why… |
Congratulations are in order! |
Depends on Gulp zipping
EDIT by @ffoodd
/webextension
) : scripts, translations, etc.master
The text was updated successfully, but these errors were encountered: