Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package extension #292

Closed
19 tasks done
notabene opened this issue Dec 5, 2017 · 14 comments
Closed
19 tasks done

Package extension #292

notabene opened this issue Dec 5, 2017 · 14 comments
Assignees

Comments

@notabene
Copy link
Collaborator

notabene commented Dec 5, 2017

Depends on Gulp zipping

  • Firefox: package and deploy locally
  • Firefox: check storage
  • Firefox: publish on store
  • Chrome: package and deploy locally
  • Chrome: check storage
  • Chrome: publish on store

EDIT by @ffoodd

  • close Add a tool to check 1-4-12 criterion (WCAG 2.1) #325 and Missing translations: pt-br & zh a11y.css-webextension#13 (I think we're going with FR+EN only for now…)
  • improve UI in [webextension] — Improve UI #346
  • package webextensions
  • publish to Firefox add-on + Chrome webstore
  • update documentation website
  • update wiki (to document webextension itself)
    • Assets pipeline (both in FR and EN)
    • grouping pages through: usage (to include edge cases, customization and pipeline) and contribution (with doc and translation)
    • add somehow webextension technical documentation (already started as a markdown file in /webextension) : scripts, translations, etc.
    • and improve main README to at least include wiki's home & website's home contents.
  • update SassDoc theme for sidebar + main nav
  • merge on master
  • bump a major version (git tag + release + npm publish)
@notabene notabene self-assigned this Dec 5, 2017
@notabene notabene changed the title Package extension step 1. Firefox Package extension Jan 9, 2018
@notabene
Copy link
Collaborator Author

Zip works locally as per commit 803cefe

notabene added a commit that referenced this issue Jan 17, 2018
notabene added a commit that referenced this issue Jan 17, 2018
@notabene
Copy link
Collaborator Author

Firefox: done \o/

ffoodd added a commit that referenced this issue Feb 7, 2019
@ffoodd
Copy link
Owner

ffoodd commented Feb 7, 2019

Packaging task and local upload works for Chromium.
Still needs browser compatibility improvement, though…

@ffoodd
Copy link
Owner

ffoodd commented Mar 18, 2019

checkAlts is now fully working in Chromium! Just needs to check storage and publish on store.

IMHO starting an Edge version is probably too much, since it'll switch to Blink soon. What's your opinion, @notabene ?

And FWIW, I'll try to improve UI too before release new version on stores.

@notabene
Copy link
Collaborator Author

notabene commented Mar 18, 2019 via email

@notabene
Copy link
Collaborator Author

@ffoodd shouldn't this issue be closed if you're OK with Chrome? (can't test it, don't have it, don't want it) ;)

@ffoodd
Copy link
Owner

ffoodd commented Apr 18, 2019

@notabene Still need to check storage (don't really know what to check) and to publish on store.

I'll finish #325 + try to close ffoodd/a11y.css-webextension#13 (or document it), then improve UI a bit before releasing it to Chrome add-on webstore: that'll make (IMHO) the first milestone for webextension, meaning that I'll merge it to master and make it the official recommended usage.

So before it's done:

@ffoodd
Copy link
Owner

ffoodd commented Apr 26, 2019

@notabene I just published a 1.0.6 on firefox add-ons (and currently waiting for approval on chrome's webstore). I’d like you to test a bit before definetely merging this first version on master, and recommending it as the main a11y.css usage on the wiki + website :)

I may have missed something…

@notabene
Copy link
Collaborator Author

notabene commented Apr 28, 2019

Not good. As I told you the other day, I haven't found yet how to store a state when going from one tab to another. Your evolution does not work as expected.

Steps to reproduce:

  1. open two tabs
  2. in tab 1, toggle one option On
  3. switch to tab 2
  4. come back to tab 1: the option is Off although the setting is still applied to the page.

If you look into the Web Developer extension you'll see the same problem. I'm not sure an extension has the right to access a tab when you switch back to it.

I'd suggest keeping to the old method for now, and getting rid of the switch boxes.

@ffoodd
Copy link
Owner

ffoodd commented Apr 28, 2019

@notabene Hii thanks for checking in!
I totally forgot this, focusing on UI. However!

I just pushed something: I managed to use storage for each setting, and it's working in both Firefox and Chromium. It's not done yet:

  • in active tab, following a link to another page keeps the storage value; I'm not sure about what to do here:
    1. cleaning storage when activating a link?
    2. keeping storage but activate setting on the new page?
  • I think popuphandlers.js is dead code, isn't it?

FWIW we're getting closer and closer to a first fully working version, and that's nice!

@ffoodd
Copy link
Owner

ffoodd commented Apr 29, 2019

Maybe @GaetanBt could help a bit?

@ffoodd
Copy link
Owner

ffoodd commented May 1, 2019

After some tries, I managed to get the current tab id with @notabene code part in checkAlts :

browser.tabs.query({ active: true, currentWindow: true }).then((tabs) => {
	console.log(tabs[0].id);
});

I don't know if I'll be able to make a helper for this, since browser.tabs.getCurrent() does not work (either missing permission, or not applicable in this context… maybe both).

Let's try by repeating this for now.

The only part missing now is to use this to contextually store states and values for a specific tab, and prevent a tab's values from override another one's.

@ffoodd
Copy link
Owner

ffoodd commented May 2, 2019

@notabene I just pushed a 1.0.7 to Firefox add-ons, that correctly handle tab specific storage in Firefox.

However this does not work on Chromium for now, and I have no idea why…

@notabene
Copy link
Collaborator Author

Congratulations are in order!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants