empty elementOfJsonPath

[vegterb]

return null with empty elementOfJsonPath

[fhoeben]

Looks good. Would you mind adding a test?

[vegterb]

JsonFixtureTest Class & two tests added

[fhoeben]

Looks good. A few minor points to finish it I believe

[vegterb]

@fhoeben changes made, thanks for the feedback.

[fhoeben]

Just remembered JsonHttpTest: has its own handling (if only Java had mixins) of getting elements. Please make the same change there.
Sorry for not mentioning it earlier...

[vegterb]

@fhoeben as per your comment I updated JsonHttpTest but got a bit stuck on the unit test in JsonHttpTestTest, my girlfriend suggested Mockito, which was already part of your project so I also updated the JsonFixtureTest. Let me know what you think.

[fhoeben]

Although I really like mockito, I try to keep away from using spies as much as possible as they tend to couple your test too tightly to the implementation. Instead I suggest you take a look at wiki/FitNesseRoot/HsacAcceptanceTests/SlimTests/HttpTest/JsonHttpTest.wiki line 30, I believe adding one line there to check element 2 would be the easiest way to test the changed behaviour (line 30 tests the behaviour when the element is present)

[vegterb]

I could of course not use the spy implementation and just use a mock for the HttpResponse class and keep using all the methodes within the 'JsonHttpTest' class. It's you're call... mock or revert and use:
|check |element |2 |of json path|airplanes[?(@.airline=='KLM')].type|null|
is also no problem.

I will revert the changes in the 'JsonFixtureTest'.

[vegterb]

It's an interesting thought though as with a spy I would isolate the specific method and I'm not dependent on changes in other methods. Isn't the FitNesse test therefore not more dependent on the implementation?

[fhoeben]

I would prefer |check |element |2 |of json path|airplanes[?(@.airline=='KLM')].type|null|

The spy indeed isolates the specific method, but that method is the implementation detail. The FitNesse test checks the behaviour of the class given a certain response from the remote server, it's completely decoupled from how the fixture arrives at that response. So JsonHttpTest could be completely refactored (for instance by delegating to JsonFixture, or even rewriting it in Kotlin) and the test needs no change: it still verifies whether the correct response is given.

[vegterb]

@fhoeben all changes made, should be good now.

[fhoeben]

Looks good. One minor thing left