Bump version numbers for release #216
Conversation
|
@Stebalien I'm a little confused as to the versioning of crates such as fvm_shared, fvm, fvm_sdk. Within a given project, is it recommended/necessary to have only one minor version of any of these particular crates? I.e. if a project pulls in dependencies that specify both fvm_shared@3.2 and fvm_shared@3.3 is this ok or are they considered incompatible? In that case, in this repo we generally bump major versions when upgrading these dependencies to signal to our consumers that these changes are incompatible and need to be updated in line with the fvm crates. However, would bumping minor versions in a PR here be sufficient? |
alexytsu
changed the title
Yeah.... See filecoin-project/ref-fvm#1724. Basically, we've been versioning the FVM 1, 2, 3, etc. with for major incompatible network upgrades. Which means API breaking changes get minor version bumps. And yeah, this is incorrect. My goal is to turn all of this into |
I'm also moving all the version specifications to the workspace to ensure we always use the same versions and to make future updates easier.
alexytsu
force-pushed
the
alex/update-fvm-ipld
branch
from
f6c14ab
to
23a7f84
Compare
| [patch.crates-io] | ||
| fvm_actor_utils = { git = "https://github.com/helix-onchain/filecoin", branch = "alex/update-fvm-ipld" } | ||
| frc42_dispatch = { git = "https://github.com/helix-onchain/filecoin", branch = "alex/update-fvm-ipld" } | ||
| frc46_token = { git = "https://github.com/helix-onchain/filecoin", branch = "alex/update-fvm-ipld" } |
There was a problem hiding this comment.
we need builtin-actors filecoin-project/builtin-actors#1330 to be updated to the same versions of FVM in order to build integration tests here. (Though technically we should be able to release the packages off this branch without passing the integration tests).
That builtin-actors commit patches back to this branch in order to bump its use of helix-libraries alongside underlying FVM versions. The issue now is that helix-filecoin depends on bactors (as a git patch) which depends back on helix-filecoin (as a git patch). However, when building from helix-filecoin, the bactors -> helix-filecoin dep is trying to pull in the helix crates from crates.io. Hence here we have to patch back to ourselves.
After the helix crates are released to crates.io we should then
- remove this
- remove the patch for helix libraries in Update FVM types builtin-actors#1330
- land Update FVM types builtin-actors#1330
- patch our integration tests here to the
mastercommit of bactors
|
@Stebalien could you ptal |
There was a problem hiding this comment.
LGTM. One thing we should consider would be fixing the builtin actor's build system to apply patches when building actors. Substrate's wasm-builder does that but we were going for a "clean build". Bug given that the build isn't reproducible anyways.... it likely doesn't matter.
Note: I'm not sure how |
Preps new version numbers to land once we have switched to stable rust
TODO