fix: offsets to CAR section starts #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these are required for carv2 indexes when we pass them back to a Blockstore
rvagg
force-pushed
the
rvagg/fix/commp
branch
from
921ca18
to
6b8a7b3
Compare
rvagg
force-pushed
the
rvagg/fix/commp
branch
from
d1658e9
to
dddae10
Compare
willscott
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
- the need for both
HeaderSizeandPragmaSizeis unfortunate - I'm unconvinced that the pain we force when boost using an un-aligned index is better than Add an
AbsoluteIndexOffsetsoption for readonly blockstore ipld/go-car#490 but it's going to be a bit ugly either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these are required for carv2 indexes when we pass them back to a Blockstore