Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the "releases" branch #12374

Closed
4 tasks done
Tracked by #12072
BigLep opened this issue Aug 9, 2024 · 5 comments
Closed
4 tasks done
Tracked by #12072

Deprecate the "releases" branch #12374

BigLep opened this issue Aug 9, 2024 · 5 comments
Assignees
Milestone

Comments

@BigLep
Copy link
Member

BigLep commented Aug 9, 2024

Done Criteria

  1. The "releases" branch ceases to work (i.e., not able to checkout the branch and build Lotus Node or Miner by default)
  2. Anyone who attempts the above is given clear messaging and pointers to alternatives
  3. References to the branch are removed/updated

Why Important

  1. (main reason) Remove ambiguity - releases goal was to point to the latest stable tagged release of Lotus software for convenience and script. This worked when Lotus Node and Miner were released together, but with the 2024Q3 split of releasing Lotus Node and Miner separately, there isn't necessarily a single commit to track for the latest released software of both.
  2. (minor reason) Time savings - As Lotus Node maintainers seek to cleanup and simplify the Lotus Node release process, updating the releases was an additional manual step.

User/Customer

Maintainers and users building from source

Notes

  1. This is falling out from working on Revised Lotus Node/Client Versioning #12072 . It is tracked separately to give it more visibility and enable tighter scoped discussed, because it can be done separately, and to ensure none of the details get lost in a larger issue.
  2. The initial "Task Proposal" is an initial proposal by @BigLep . Feedback and suggestions welcome. I wanted to get an issue started so we could start linking to it.

Task Proposal

@BigLep
Copy link
Member Author

BigLep commented Aug 10, 2024

A draft of changes to the releases branch itself: #12375

BigLep added a commit to filecoin-project/lotus-docs that referenced this issue Aug 15, 2024
This is some followup for #754 ultimately in support of filecoin-project/lotus#12374
@BigLep
Copy link
Member Author

BigLep commented Aug 15, 2024

Archive or protect the branch so new functionality is accidentally pushed to the branch

I updated https://github.com/filecoin-project/lotus/settings/branch_protection_rules/22005102 so releases is read-only:
image

We just have a couple of docs updates to merge and then we can close this issue.

@BigLep
Copy link
Member Author

BigLep commented Aug 15, 2024

I'll items addressed. Resolving.

@rjan90
Copy link
Contributor

rjan90 commented Aug 16, 2024

I have opened up #12399 targeting the releases branch here to correct a link that got overwritten accidentally. I have therefore temporarily unlock the releases branch: https://github.com/filecoin-project/lotus/settings/branch_protection_rules/22005102 so that this change can land. I will lock the branch again, once the #12399 PR has been merged.

@rjan90
Copy link
Contributor

rjan90 commented Aug 16, 2024

The releases branch has now been locked to read-only again: #12399 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

No branches or pull requests

2 participants