Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add some initialization helpers to the sdk #896

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Conversation

Stebalien
Copy link
Member

This replaces the custom assert macros. Instead of overriding the assert macros, the user would:

  1. Call fvm_sdk::initialize() at the top of their actor/tests.
  2. Use the default assert macros.

replaces #660

This replaces the custom assert macros. Instead of overriding the assert
macros, the user would:

1. Call `fvm_sdk::initialize()` at the top of their actor/tests.
2. Use the default `assert` macros.

replaces #660
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #896 (9c7aa10) into master (2705679) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #896   +/-   ##
=======================================
  Coverage   52.01%   52.02%           
=======================================
  Files         124      124           
  Lines       10191    10230   +39     
=======================================
+ Hits         5301     5322   +21     
- Misses       4890     4908   +18     
Impacted Files Coverage Δ
sdk/src/debug.rs 0.00% <ø> (ø)
sdk/src/lib.rs 12.50% <0.00%> (-12.50%) ⬇️
sdk/src/vm.rs 0.00% <0.00%> (ø)
ipld/encoding/src/cbor.rs 40.67% <0.00%> (+31.30%) ⬆️

Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what happens if the user doesnt call the initializer?

@Stebalien
Copy link
Member Author

The actor will abort with "illegal instruction" instead of a more helpful error message.

@vyzo
Copy link
Contributor

vyzo commented Oct 6, 2022

ok, nothing deleterious.

@Stebalien Stebalien merged commit f1390d9 into master Oct 6, 2022
@Stebalien Stebalien deleted the feat/sdk-setup branch October 6, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants