Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prettify test failures #223

Merged
merged 3 commits into from
May 22, 2023
Merged

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented May 18, 2023

Vendor format_test_error() from Deno CLI and use it to format test failures.

Output before my changes - notice the stack frames pointing to Zinnia internals (ext:zinnia_runtime)

Screenshot 2023-05-18 at 12 57 08

New output:

Screenshot 2023-05-18 at 12 55 37

Output of deno test for comparison:

Screenshot 2023-05-18 at 13 00 24

See #44

Vendor `format_test_error()` from Deno CLI and use it to format
test failures.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos requested a review from juliangruber May 18, 2023 11:01
@bajtos bajtos mentioned this pull request May 18, 2023
5 tasks
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅 Clean!

@bajtos bajtos enabled auto-merge (squash) May 22, 2023 12:28
@bajtos bajtos merged commit caf5b73 into main May 22, 2023
@bajtos bajtos deleted the feat-nicer-assertion-stack-traces branch May 22, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants