Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links to documentation in README.md #102

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Update links to documentation in README.md #102

merged 1 commit into from
Jun 3, 2019

Conversation

howard
Copy link
Collaborator

@howard howard commented Jun 3, 2019

Purpose

Restructuring in the documentation page lead to links being outdated.

Approach

Update the links.

Open Questions and Pre-Merge TODOs

  • composer lint and composer fix was executed.
  • Tests were written and pass with 100% coverage.
  • A issue with a detailed explanation of the problem/enhancement was created and linked.

@howard howard self-assigned this Jun 3, 2019
@howard howard requested a review from TheKeymaster June 3, 2019 07:27
TheKeymaster
TheKeymaster approved these changes Jun 3, 2019
View reviewed changes
Copy link

@TheKeymaster TheKeymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@howard howard merged commit 902d1e6 into develop Jun 3, 2019
@howard howard deleted the update_docs_links branch June 3, 2019 08:53
@howard
Copy link
Collaborator Author

howard commented Jun 3, 2019

@TheKeymaster Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheKeymaster TheKeymaster TheKeymaster approved these changes

Assignees

@howard howard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@howard @TheKeymaster