Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify workflow to build at midnight as well as pushes #120

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

howard
Copy link
Collaborator

@howard howard commented Feb 24, 2020

Purpose

In case dependencies break, or there is incompatibility with new minor releases of a PHP version in periods where libflexport is updated infrequently, the library could break without anyone knowing, because there are no periodic builds.

Approach

In addition to pushes, build daily at midnight.

Open Questions and Pre-Merge TODOs

  • composer lint and composer fix was executed. workflow change.
  • Tests were written and pass with 100% coverage.
  • A issue with a detailed explanation of the problem/enhancement was created and linked. overkill.

@howard howard self-assigned this Feb 24, 2020
@codecov-io
Copy link

Codecov Report

Merging #120 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             develop   #120   +/-   ##
========================================
  Coverage        100%   100%           
  Complexity       269    269           
========================================
  Files             49     49           
  Lines            700    700           
========================================
  Hits             700    700
Flag Coverage Δ Complexity Δ
#unittests 100% <ø> (ø) 269 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c89d0...d2ebfe6. Read the comment docs.

@howard howard merged commit 81be166 into develop Feb 24, 2020
@TobiasGraml11 TobiasGraml11 deleted the configure_nightly_builds branch July 7, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants