Support PHP 8 #128
Merged
Support PHP 8 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPUnit 9.3 ready and update workflows Also add stability for php 7 Execute all builds Remove minimum stability config of composer Fix risky tests Update
mmachatschek
force-pushed
the
test_php8
branch
from
af5f953
to
f69e3b5
Compare
howard
approved these changes
Nov 24, 2020
|
@mmachatschek Thanks for the upgrade! Merging this, but the release will have to wait for the official PHP 8 release date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds CI tests for PHP 8 and updates the CI workflows.
Approach
Add PHP 8 to workflow matrix and allow it in the composer file. Also add new phpunit configuration file.
Open Questions and Pre-Merge TODOs
composer lintandcomposer fixwas executed.A issue with a detailed explanation of the problem/enhancement was created and linked.