Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that sort value is integer #52

Merged
merged 1 commit into from
Apr 29, 2018
Merged

Conversation

mmachatschek
Copy link
Contributor

As described in our XSD-Schema, the value of the sort element has to be an integer.

@codecov-io
Copy link

codecov-io commented Mar 31, 2018

Codecov Report

Merging #52 into develop will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #52      +/-   ##
=============================================
+ Coverage      91.07%   91.21%   +0.13%     
- Complexity       181      185       +4     
=============================================
  Files             30       30              
  Lines            504      512       +8     
=============================================
+ Hits             459      467       +8     
  Misses            45       45
Impacted Files Coverage Δ Complexity Δ
src/FINDOLOGIC/Export/Data/Sort.php 100% <100%> (ø) 5 <4> (+4) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0728e2...29b63d4. Read the comment docs.

Copy link
Collaborator

@howard howard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@howard howard merged commit 6f5eb16 into develop Apr 29, 2018
@howard howard deleted the validate_sort_as_integer branch April 29, 2018 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants