Improve code coverage and fix bug #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #55 +/- ##
=============================================
+ Coverage 98.98% 99.83% +0.84%
- Complexity 220 221 +1
=============================================
Files 30 30
Lines 592 593 +1
=============================================
+ Hits 586 592 +6
+ Misses 6 1 -5
Continue to review full report at Codecov.
|
mmachatschek
changed the title
howard
requested changes
Jun 4, 2018
| $this->values = []; | ||
|
|
||
| /* @var UsergroupAwareMultiValueItem $value */ | ||
| foreach ($values as $value) { |
There was a problem hiding this comment.
Adding in a loop is super inefficient when we could just assign the input array. To achieve 100% coverage, I'd rather have a test that just gets the value.
There was a problem hiding this comment.
Forget what I said. I now realize that this fixes a bug.
howard
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will increase code coverage to 100%.
There is also a fix implemented which led to not existing keywords and ordernumbers if added via the setAllxyz method.