Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention encoding limitations #57

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Mention encoding limitations #57

merged 2 commits into from
Jun 5, 2018

Conversation

howard
Copy link
Collaborator

@howard howard commented Jun 5, 2018

Fixes #53 .

@howard howard requested a review from mmachatschek June 5, 2018 07:54
@codecov-io
Copy link

codecov-io commented Jun 5, 2018 •
edited
Loading

Codecov Report

Merging #57 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #57    +/-   ##
=========================================
  Coverage        100%   100%            
- Complexity       223    272    +49     
=========================================
  Files             30     30            
  Lines            597    714   +117     
=========================================
+ Hits             597    714   +117
Impacted Files Coverage Δ Complexity Δ
src/FINDOLOGIC/Export/Data/Attribute.php 100% <0%> (ø) 10% <0%> (ø) ⬇️
src/FINDOLOGIC/Export/Data/Item.php 100% <0%> (ø) 89% <0%> (+40%) ⬆️
...OLOGIC/Export/Helpers/UsergroupAwareMultiValue.php 100% <0%> (ø) 13% <0%> (+3%) ⬆️
...LOGIC/Export/Helpers/UsergroupAwareSimpleValue.php 100% <0%> (ø) 10% <0%> (ø) ⬇️
src/FINDOLOGIC/Export/Data/Property.php 100% <0%> (ø) 17% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ee481...673175c. Read the comment docs.

mmachatschek
mmachatschek suggested changes Jun 5, 2018
View reviewed changes
Copy link
Contributor

@mmachatschek mmachatschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little thing missing.

README.md Outdated

* Convert all text to UTF-8 prior to passing it to `libflexport`.
* Use the XML exporter and modify the library to change the XML header to contain the required encoding.
* FINDOLOGIC is capable for handling most encodings, but only with XML.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to capable of

@howard howard merged commit f58ac67 into develop Jun 5, 2018
@howard howard deleted the document_limitations branch June 5, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmachatschek mmachatschek mmachatschek approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howard @codecov-io @mmachatschek