Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): Fix PreferRest caching issue #2040

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Conversation

lahirumaramba
Copy link
Member

@lahirumaramba lahirumaramba commented Jan 13, 2023

  • Fixed a caching issue when a non-empty FirestoreSettings object is passed to initializeFirestore(...)
  • Improved test coverage for initializeFirestore()

Before:

initializeFirestore(app)
getFirestore(app) // works!

---

initializeFirestore(app, {})
getFirestore(app) // works!

---

initializeFirestore(app, { preferRest: true })
getFirestore(app) // throws `firestore/failed-precondition` error!

Related to: #1901

Copy link

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants