Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(fcm): Deprecate sendToDevice and sendToDeviceGroup and their response classes #2090

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

Doris-Ge
Copy link
Contributor

  • Deprecate sendToDevice and its response class, MessagingDeviceResponse
  • Deprecate sendToDeviceGroup and its response class, MessagingDeviceGroupResponse

@Doris-Ge Doris-Ge force-pushed the remotes/dorisge/deprecate-legacy-send-apis branch 3 times, most recently from a271310 to e84d85f Compare March 1, 2023 19:49
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Doris-Ge ! LGTM!
Let's get a TW review as well.

@lahirumaramba
Copy link
Member

Adding @egilmorez to review the docs changes. Thanks!

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG with a nit, thanks!

/**
* Individual status response payload from single devices
*
* @deprecated Returned by {@link Messaging#sendToDevice} which is also deprecated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but "which" is generally preceded by a comma. Suggest one here and for similar/identical instances below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks! Done.

@Doris-Ge Doris-Ge force-pushed the remotes/dorisge/deprecate-legacy-send-apis branch from e84d85f to fd016e0 Compare March 2, 2023 20:09
1. Deprecate sendToDevice and its response class, MessagingDeviceResponse
2. Deprecate sendToDeviceGroup and its response class, MessagingDeviceGroupResponse
@Doris-Ge Doris-Ge force-pushed the remotes/dorisge/deprecate-legacy-send-apis branch from fd016e0 to 16ba83a Compare March 2, 2023 20:10
@Doris-Ge Doris-Ge merged commit 8879fe0 into master Mar 2, 2023
@Doris-Ge Doris-Ge deleted the remotes/dorisge/deprecate-legacy-send-apis branch March 2, 2023 20:19
@lahirumaramba lahirumaramba changed the title Deprecate sendToDevice and sendToDeviceGroup and their response classes change(fcm): Deprecate sendToDevice and sendToDeviceGroup and their response classes Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants