Catch more heartbeat read/write errors (#7272)

firebase · May 1, 2023 · e0551fa · e0551fa
1 parent 8051e4a
commit e0551fa
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/sixty-dolls-report.md b/.changeset/sixty-dolls-report.md
@@ -0,0 +1,5 @@
+---
+'@firebase/app': patch
+---
+
+Catch more heartbeat read/write errors.
diff --git a/packages/app/src/indexeddb.ts b/packages/app/src/indexeddb.ts
@@ -62,10 +62,11 @@ export async function readHeartbeatsFromIndexedDB(
 ): Promise<HeartbeatsInIndexedDB | undefined> {
   try {
     const db = await getDbPromise();
-    return db
+    const result = await db
       .transaction(STORE_NAME)
       .objectStore(STORE_NAME)
-      .get(computeKey(app)) as Promise<HeartbeatsInIndexedDB | undefined>;
+      .get(computeKey(app));
+    return result;
   } catch (e) {
     if (e instanceof FirebaseError) {
       logger.warn(e.message);
@@ -87,7 +88,7 @@ export async function writeHeartbeatsToIndexedDB(
     const tx = db.transaction(STORE_NAME, 'readwrite');
     const objectStore = tx.objectStore(STORE_NAME);
     await objectStore.put(heartbeatObject, computeKey(app));
-    return tx.done;
+    await tx.done;
   } catch (e) {
     if (e instanceof FirebaseError) {
       logger.warn(e.message);