Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch transaction.done errors #7984

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Catch transaction.done errors #7984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d59567
Catch transaction.done errors
hsubox76 Jan 26, 2024
8ddc7e3
format
hsubox76 Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/few-drinks-kiss.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@firebase/app': patch
---

Catch `transaction.done` errors in `readHeartbeatsFromIndexedDB` and log them as a warning, because platform logging errors should never throw or block user app functionality.
9 changes: 5 additions & 4 deletions packages/app/src/indexeddb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,11 @@ export async function readHeartbeatsFromIndexedDB(
): Promise<HeartbeatsInIndexedDB | undefined> {
try {
const db = await getDbPromise();
const result = await db
.transaction(STORE_NAME)
.objectStore(STORE_NAME)
.get(computeKey(app));
const tx = db.transaction(STORE_NAME);
const result = await tx.objectStore(STORE_NAME).get(computeKey(app));
// We already have the value but tx.done can throw,
// so we need to await it here to catch errors
await tx.done;
return result;
} catch (e) {
if (e instanceof FirebaseError) {
Expand Down
Loading