Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector Type #8215

Merged
merged 18 commits into from
Aug 12, 2024
Merged

Vector Type #8215

merged 18 commits into from
Aug 12, 2024

Conversation

MarkDuckworth
Copy link
Contributor

@MarkDuckworth MarkDuckworth commented May 3, 2024

Add support for reading and writing Firestore vectors.

Copy link

changeset-bot bot commented May 3, 2024

🦋 Changeset detected

Latest commit: 76f2972

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Minor
firebase Minor
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 3, 2024

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (1601572)Merge (db4462e)Diff
    browser379 kB381 kB+2.16 kB (+0.6%)
    esm5364 kB366 kB+1.94 kB (+0.5%)
    main584 kB587 kB+3.37 kB (+0.6%)
    module379 kB381 kB+2.16 kB (+0.6%)
    react-native379 kB382 kB+2.16 kB (+0.6%)
  • @firebase/firestore-lite

    TypeBase (1601572)Merge (db4462e)Diff
    browser109 kB111 kB+1.70 kB (+1.6%)
    esm5106 kB108 kB+1.56 kB (+1.5%)
    main150 kB153 kB+2.55 kB (+1.7%)
    module109 kB111 kB+1.70 kB (+1.6%)
    react-native109 kB111 kB+1.70 kB (+1.6%)
  • bundle

    15 size changes

    TypeBase (1601572)Merge (db4462e)Diff
    firestore (CSI Auto Indexing Disable and Delete)269 kB270 kB+934 B (+0.3%)
    firestore (CSI Auto Indexing Enable)269 kB270 kB+934 B (+0.3%)
    firestore (Persistence)304 kB305 kB+934 B (+0.3%)
    firestore (Query Cursors)241 kB242 kB+1.38 kB (+0.6%)
    firestore (Query)238 kB240 kB+1.38 kB (+0.6%)
    firestore (Read data once)226 kB228 kB+1.09 kB (+0.5%)
    firestore (Read Write w Persistence)323 kB325 kB+1.74 kB (+0.5%)
    firestore (Realtime updates)229 kB230 kB+1.09 kB (+0.5%)
    firestore (Transaction)205 kB207 kB+1.38 kB (+0.7%)
    firestore (Write data)205 kB207 kB+1.12 kB (+0.5%)
    firestore-lite (Query Cursors)89.8 kB91.2 kB+1.38 kB (+1.5%)
    firestore-lite (Query)85.9 kB87.3 kB+1.38 kB (+1.6%)
    firestore-lite (Read data once)62.1 kB62.8 kB+702 B (+1.1%)
    firestore-lite (Transaction)87.1 kB88.1 kB+995 B (+1.1%)
    firestore-lite (Write data)71.7 kB72.4 kB+730 B (+1.0%)

  • firebase

    TypeBase (1601572)Merge (db4462e)Diff
    firebase-compat.js786 kB788 kB+1.65 kB (+0.2%)
    firebase-firestore-compat.js342 kB344 kB+1.65 kB (+0.5%)
    firebase-firestore-lite.js117 kB119 kB+1.69 kB (+1.4%)
    firebase-firestore.js438 kB440 kB+2.15 kB (+0.5%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JkIdGeBE4F.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 3, 2024

Size Analysis Report 1

This report is too large (631,171 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/upTLCZuj2j.html

@MarkDuckworth MarkDuckworth marked this pull request as ready for review July 29, 2024 22:51
@MarkDuckworth MarkDuckworth requested review from a team as code owners July 29, 2024 22:51
@MarkDuckworth MarkDuckworth requested a review from a team as a code owner August 6, 2024 15:57
@MarkDuckworth MarkDuckworth requested a review from a team as a code owner August 6, 2024 18:40
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG with tiny nits, thanks!

In a review this size, it would be great to have a way to know which files are not public-facing, like an exclusion list. I'll ask Christina about that.

docs-devsite/firestore_.md Outdated Show resolved Hide resolved
@MarkDuckworth MarkDuckworth merged commit e6b8525 into main Aug 12, 2024
42 of 43 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/vector-type branch August 12, 2024 13:38
This was referenced Aug 13, 2024
@dlarocque dlarocque mentioned this pull request Aug 21, 2024
@firebase firebase locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants