Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to ESLint 8 #8384

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Upgrade to ESLint 8 #8384

merged 2 commits into from
Jul 25, 2024

Conversation

dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Jul 22, 2024 •
edited
Loading

Upgrade to ESLint 8. This fixes a peer dependency issue:

warning " > eslint-plugin-import@2.26.0" has incorrect peer dependency "eslint@^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8".

I tested this works by running yarn lint, and yarn api-extractor.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8758d33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dlarocque dlarocque marked this pull request as draft July 22, 2024 16:59
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 22, 2024 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (14b7720) and merge commit (a53a759).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/e5w9YwwWoy.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 22, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (14b7720) and merge commit (a53a759).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bzwrRDYpAw.html

@dlarocque dlarocque marked this pull request as ready for review July 22, 2024 20:25
@dlarocque dlarocque requested review from hsubox76 and a team as code owners July 22, 2024 20:25
DellaBitta
DellaBitta reviewed Jul 22, 2024
View reviewed changes
packages/analytics/src/helpers.ts Outdated Show resolved Hide resolved
packages/auth-compat/test/helpers/helpers.ts Outdated Show resolved Hide resolved
packages/firestore/src/util/async_queue_impl.ts Outdated Show resolved Hide resolved
packages/firestore/src/util/async_queue_impl.ts Outdated Show resolved Hide resolved
@dlarocque dlarocque merged commit e542f1d into master Jul 25, 2024
43 checks passed
@dlarocque dlarocque deleted the dlarocque/eslint-8 branch July 25, 2024 19:34
@firebase firebase locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@lisajian lisajian Awaiting requested review from lisajian

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh

@sam-gc sam-gc Awaiting requested review from sam-gc

@DellaBitta DellaBitta Awaiting requested review from DellaBitta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlarocque @google-oss-bot @DellaBitta @hsubox76