Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade actions from master to v4 #8400

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Upgrade actions from master to v4 #8400

merged 1 commit into from
Jul 30, 2024

Conversation

dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Jul 29, 2024

The actions/checkout was being pulled from @master which is still at v2, since their default branch has changed from master to main in 2020.

Previous default branch, at v2: https://github.com/actions/checkout/tree/master
New default branch, at v4: https://github.com/actions/checkout/tree/main

The v2 -> v3 bump was to drop support for Node runtimes < 16: actions/checkout@v2.4.2...v3.0.2#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R17-R18
The v3 -> v4 bump was to drop support for Node runtimes < 20: actions/checkout@v4.0.0...v4.1.0#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R15-R17

Since we're already using Node >= 20, we can upgrade all the way to v4.

The `actions/checkout` was being pulled from @master which is still at
v2, since their default branch has changed from master to main in 2020.
We should change the tag to pull from v4 instead.
@dlarocque dlarocque requested a review from a team as a code owner July 29, 2024 15:31
Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: 3fb7f5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@dlarocque dlarocque requested a review from hsubox76 July 29, 2024 19:52
@dlarocque dlarocque merged commit 23581c6 into main Jul 30, 2024
35 checks passed
@dlarocque dlarocque deleted the dlarocque/checkout-v4 branch July 30, 2024 20:51
@firebase firebase locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants