Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update undici dependency #8432

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Update undici dependency #8432

merged 5 commits into from
Aug 20, 2024

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Aug 16, 2024 •
edited
Loading

Discussion

Update our dependency on Undici to 6.19.7. Earlier implementations contained a memory leak.

Fixes #8431.

Testing

CI.

API Changes

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b536b94

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@firebase/auth-compat Patch
@firebase/firestore Patch
@firebase/functions Patch
@firebase/storage Patch
@firebase/auth Patch
firebase Patch
@firebase/storage-compat Patch
@firebase/firestore-compat Patch
@firebase/functions-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 16, 2024 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (f7c6dc4) and merge commit (fa509fe).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZREl9YAub7.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 16, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (f7c6dc4) and merge commit (fa509fe).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6GITdawjyl.html

@DellaBitta DellaBitta marked this pull request as ready for review August 19, 2024 18:23
@dlarocque dlarocque mentioned this pull request Aug 19, 2024
Closed
@DellaBitta DellaBitta merged commit 62348e1 into main Aug 20, 2024
43 checks passed
@DellaBitta DellaBitta deleted the ddb-undici branch August 20, 2024 13:38
@google-oss-bot google-oss-bot mentioned this pull request Aug 27, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@dlarocque dlarocque dlarocque approved these changes

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@zwu52 zwu52 Awaiting requested review from zwu52 zwu52 is a code owner

@maneesht maneesht Awaiting requested review from maneesht maneesht is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang tonyjhuang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undici <v6.16.0 memory ballooning bug
4 participants
@DellaBitta @google-oss-bot @hsubox76 @dlarocque