Make VertexAIError error codes use the vertex type prefix #8542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
code
argument being passed (e.g.fetch-error
) wasreadonly
, it was overriding the prefixed error code that is set in the super constructor (vertexAI/fetch-error
). So the error code users would see would not be prefixed. We should include the prefix, since that's what the other products do. Instead of fixing this by just makingcode
notreadonly
, we should just add the prefix directly to the enum value, so that users can check error codes more safely. Otherwise they'd have access to the non-prefixed errors, and would have to prefix it themselves if they want to actually use it-if (err.code === 'vertexAI/${VertexAIErrorCode.FETCH_ERROR}') {...}
For example: