-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
International shipping additions #75
Conversation
… LA,UA,RI labels, other fixes and improvement
Feature/added missing address field
…ignature instead of Signature model in LabellingService, other fixes and improvements
…ng status of shipment failed
…de generation e.g. LAxxxxxxxxxxNL, Added Signature (via image) to GenerateLabel.php Entity so added Signature will be printed on the generated label. GB (United Kingdom) is not an 3S (EU-country) anymore, updated tests.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1.3.x #75 +/- ##
============================================
- Coverage 57.45% 57.34% -0.12%
- Complexity 2036 2046 +10
============================================
Files 114 115 +1
Lines 5103 5523 +420
============================================
+ Hits 2932 3167 +235
- Misses 2171 2356 +185
Continue to review full report at Codecov.
|
Thanks so much for the pull request! Can you tell me which commits I should have a look at? I see commits made by timmtim, but some of these have already either been included or excluded. Have you changed these commits? Or should I only focus on yours? |
It's sufficient to only focus on the current changes only. the (older) commits have been made on an older fork of this library when it was maintained by thirtybees. We updated our fork with your changes, and backported the features that where missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me!
I wonder if this may need to be adjusted:
Lines 1003 to 1005 in bd07589
if (in_array($type, ['LA', 'UE', 'RI'])) { | |
$range = 'NL'; | |
} elseif (in_array($type, ['2S', '3S'])) { |
Using International Mail & Packets without setting a range should throw an exception instead of setting the range to
NL
, which is probably invalid anyway.
Anyhow, this should be enough for now to merge the pull request.
Due to the large history of commits in the PR, I'll squash the commits before merging them into the main branch. This PR might then end up having a closed
status rather than merged
.
Thanks for your contribution!
Changes:
LA