Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#87): allow getMessagesDescriptionsAndCodes for single Error #88

Conversation

annuh
Copy link
Contributor

@annuh annuh commented Dec 14, 2023

Fixes #87.

This PR fixes two issues:

  1. Calling CifException::getMessagesDescriptionsAndCodes with a single Error:
Typed property Firstred\PostNL\Exception\CifException::$messages must not be accessed before initialization
  1. Fix incorrect PostNL error response for single Error (and allow future changes...)
Received According to PostNL API 😩
image image

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #88 (04d8ec5) into v2.0.x (1a1dc6c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             v2.0.x      #88      +/-   ##
============================================
+ Coverage     69.06%   69.12%   +0.06%     
  Complexity     2211     2211              
============================================
  Files           124      124              
  Lines          6429     6436       +7     
============================================
+ Hits           4440     4449       +9     
+ Misses         1989     1987       -2     
Files Coverage Δ
src/Exception/CifException.php 100.00% <100.00%> (+20.00%) ⬆️
...seProcessor/Rest/AbstractRestResponseProcessor.php 56.92% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1dc6c...04d8ec5. Read the comment docs.

@firstred firstred merged commit 555b3b6 into firstred:v2.0.x Dec 18, 2023
10 checks passed
@firstred
Copy link
Owner

Thanks a lot for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typed property Firstred\PostNL\Exception\CifException::$messages must not be accessed before initialization
2 participants