CLI disconnect/reconnect on every retry #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expede
changed the title
expede
commented
Oct 9, 2021
| @@ -14,7 +14,7 @@ extra-deps: | |||
| - cryptostore-0.2.1.0 | |||
| - dimensions-2.1.1.0 | |||
| - hfsevents-0.1.6 | |||
| - ipfs-1.3.1 | |||
| - ipfs-1.4.0 | |||
There was a problem hiding this comment.
Adds the IPFS.Peer.disconnect function
expede
commented
Oct 9, 2021
Comment on lines
+118
to
+119
| swarmDisconnect peers | ||
| swarmConnectWithRetry peers 25 |
matheus23
approved these changes
Oct 11, 2021
expede
added
🐛 bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of course now that I have this fix, it hasn't had to retry 😛 🤷♀️ This doesn't solve whatever our underlying networking problem is, but gives the CLI a better change of self-correcting in the field.