Move ipfs into repo, backport debug fixes #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expede
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a few changes from #536
A note on porting
ipfs-haskellto this repo: I went back and forth on this. This is really a consequence of us needing more integration tests in theipfspackage. Including it here in the monorepo is suboptimal for several reasons, including the tendency to couple to the dependency, running the typically unchanging tests on every PR, and so on. This is a purely practical matter of needing to debug the interface "live" from time to time. I don't love it, and hopefully it's temporary, but this is what it is for now.